Skip to content

Reuse static delegate rather than create a new one each call #12542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Reuse static delegate rather than create a new one each call #12542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Build/BackEnd/Components/Communications/LogMessagePacket.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,21 @@ namespace Microsoft.Build.BackEnd
/// </summary>
internal class LogMessagePacket : LogMessagePacketBase
{
private static readonly TargetFinishedTranslator targetFinishedTranslator = new TargetFinishedTranslator(TranslateTargetFinishedEvent);

Comment on lines +22 to +23
Copy link
Contributor

@teo-tsirpanis teo-tsirpanis Sep 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private static readonly TargetFinishedTranslator targetFinishedTranslator = new TargetFinishedTranslator(TranslateTargetFinishedEvent);

/// <summary>
/// Encapsulates the buildEventArg in this packet.
/// </summary>
internal LogMessagePacket(KeyValuePair<int, BuildEventArgs>? nodeBuildEvent)
: base(nodeBuildEvent, new TargetFinishedTranslator(TranslateTargetFinishedEvent))
: base(nodeBuildEvent, targetFinishedTranslator)
Copy link
Contributor

@teo-tsirpanis teo-tsirpanis Sep 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
: base(nodeBuildEvent, targetFinishedTranslator)
: base(nodeBuildEvent, TranslateTargetFinishedEvent)

{
}

/// <summary>
/// Constructor for deserialization
/// </summary>
private LogMessagePacket(ITranslator translator)
: base(translator, new TargetFinishedTranslator(TranslateTargetFinishedEvent))
: base(translator, targetFinishedTranslator)
Copy link
Contributor

@teo-tsirpanis teo-tsirpanis Sep 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
: base(translator, targetFinishedTranslator)
: base(translator, TranslateTargetFinishedEvent)

{
}

Expand Down