Add support for specific inner build targets to graph build #12557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkl
added
the
Area: Static Graph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11922
Context
This change allows us to specify different outer and inner builds which is useful for pack.
Changes Made
I added a new concept of "inner" targets that are used for inner builds. I kept backwards compatibility with existing logic where by default, inner build targets are just the outer build targets + inner build targets.
If we specify:
Then the correct targets are scheduled:
Testing
I added a test and left the existing ones which verify that nothing changed for existing logic. I also tested manually with the provided projects in the linked issue.
Notes