Add System.Uri::EscapeDataString to MSBuild property function allowlist #12572
+23
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10883
This PR adds
System.Uri::EscapeDataString
(andUnescapeDataString
) to the MSBuild property function allowlist, enabling developers to properly escape URI components in MSBuild projects without needing to resort to workarounds withUriBuilder.Path
.Problem
Previously, developers who needed to URL-encode strings in MSBuild had to use workarounds like manipulating
UriBuilder.Path
, which is not semantically correct and error-prone. TheSystem.Uri::EscapeDataString
method is the standard .NET approach for encoding URI data components.Solution
Added
System.Uri
to theAvailableStaticMethods
allowlist inConstants.cs
, which enables all static methods on theSystem.Uri
class includingEscapeDataString
andUnescapeDataString
.Usage
Safety
System.Uri::EscapeDataString
is a pure function with no side effects, making it completely safe for use during project evaluation. It follows the same security model as other allowed static methods likeSystem.String
andSystem.Convert
.Testing
UriBuilder
functionality remains unaffectedThis change provides a clean, semantically correct way to handle URI encoding in MSBuild without breaking any existing functionality.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.