allow a parameter to disable the live-updating nodes display #12581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new parameter (DISABLENODEDISPLAY) to the Terminal Logger that allows disabling the live-updating nodes display while preserving other Terminal Logger functionality. This change addresses performance concerns when MSBuild is executed by LLMs or other automated tools that don't benefit from live output updates.
- Introduces a new boolean field
_showNodesDisplaythat defaults to true for backward compatibility - Adds parameter parsing for
DISABLENODEDISPLAYto toggle the display off - Conditionally starts the refresh thread and calls
DisplayNodes()based on this setting
baronfel
force-pushed
the
enable-tl-node-display-disable
branch
from
520084c to
7f55c95
Compare
YuliiaKovalova
approved these changes
Sep 30, 2025
|
@rainersigwald mentioned we'd need to get VS QB approval for this at this time |
|
/backport to vs18.0 |
|
Started backporting to vs18.0: https://github.com/dotnet/msbuild/actions/runs/18165112437 |
AR-May
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #12486, but not all.
Context
This introduces a new Terminal Logger Parameter (
DISABLENODEDISPLAY) that disables the live-updating node display portion of the Terminal Logger output. This output is very wasteful when LLMs are running the build, and the hope is that we can toggle this flag automatically at the dotnet CLI level to maintain the structure benefits of TL while also not flooding the context.Changes Made
Testing
tl-node-display-disable.mp4
Notes
This will use the logic from dotnet/sdk#51054 in the SDK to turn off the live-update feature.