Skip to content

Conversation

davidwengier
Copy link
Member

@davidwengier davidwengier commented Jul 17, 2025

Going through our tests trying to find the source of the flakiness. This isn't it, but it does throw an exception during language server shut down (method not mocked) so its not exactly helping.

@davidwengier davidwengier force-pushed the FlakyTestsQuestionMark branch from 2f11efc to 7de6b4a Compare July 18, 2025 00:37
@davidwengier davidwengier changed the title Fix test flakiness Fix exception in tests Jul 22, 2025
@davidwengier davidwengier marked this pull request as ready for review July 22, 2025 04:54
@davidwengier davidwengier requested a review from a team as a code owner July 22, 2025 04:54
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@davidwengier davidwengier enabled auto-merge July 22, 2025 21:23
@davidwengier davidwengier merged commit 3511216 into dotnet:main Jul 22, 2025
11 checks passed
@davidwengier davidwengier deleted the FlakyTestsQuestionMark branch July 22, 2025 22:00
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 22, 2025
@RikkiGibson RikkiGibson modified the milestones: Next, 18.0 P1 Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants