Fixing override completion in VSCode when LSP is enabled #12039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing code worked for the most part. The main issue was that parameters for the complex edit command come in as JsonElements in this case and need to be deserialized.
davidwengier
approved these changes
Jul 17, 2025
There was a problem hiding this comment.
Love that the fix was this easy, thanks! I'm not going to block on tests because I know you're off for a bit after tomorrow, but if you did find time it would be good. In theory, since we already have non-cohosting tests that talk to the real language server, it should just be a matter of copying one of those and having the SupportsVisualStudioExtensions client capability set to false.
...c/Microsoft.CodeAnalysis.Razor.Workspaces/Completion/Delegation/DelegatedCompletionHelper.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
-Existing code worked for the most part. The main issue was that parameters for the complex edit command come in as JsonElements in this case and need to be deserialized.
Fixes:
dotnet/vscode-csharp#8310