*** WIP: Cache TagHelperDescriptor array on MetadataReference #12246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am interested in this conversation :) |
| tagHelperFeature.CollectDescriptors(assembly, results); | ||
| if (compilation.GetAssemblyOrModuleSymbol(reference) is IAssemblySymbol assembly) | ||
| { | ||
| tagHelperFeature.CollectDescriptors(assembly, descriptorsBuilder); |
There was a problem hiding this comment.
Note: This calls into the ITagHelperDescriptorProvider implementations, which already have caches of TagHelperProvider[] per IAssemblySymbol. The problem that you mentioned offline is around Compilation.GetTypeByMetaname which I believe the ITagHelperDescriptorProviders call before they hit their caches. It seems do-able to push that data into the IAssemblySymbol cache rather than create another.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider this a conversation starter