Allow Razor to create a formatting options, and send them to OOP #79458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
/azp run roslyn-integration-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| RazorNamespaceDeclarationPreference NamespaceDeclarations, | ||
| bool PreferTopLevelStatements, | ||
| int CollectionExpressionWrappingLength) | ||
| [property: DataMember] RazorSpacePlacement Spacing, |
Member
There was a problem hiding this comment.
i think you need DataMember(Order = ...) here, right?
Member
Author
There was a problem hiding this comment.
I thought that too, but the real CSharpSybtaxFormattingOptions this wraps doesn't have it, and this works fine in manual testing 🤷♂️
Guessing someone configured something, or changes something in servicehub maybe
CyrusNajmabadi
approved these changes
Jul 21, 2025
davidwengier
added a commit
to dotnet/razor
that referenced
this pull request
Jul 29, 2025
Fixes #11839 Needs dotnet/roslyn#79458 before it will compile This just tweaks the "override C# settings for tests" system we had into a formal "can specify C# settings before formatting" option, and then in cohosting we grab the options from Roslyn (via new EA API) before jumping to OOP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of dotnet/razor#11839