Skip to content

Move CoreCLR over to the managed wait subsystem #117788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 31 commits into
base: main
Choose a base branch
from
Draft

Move CoreCLR over to the managed wait subsystem #117788

wants to merge 31 commits into from

Conversation

jkoritzinsky
Copy link
Member

@jkoritzinsky jkoritzinsky commented Jul 17, 2025 •
edited
Loading

Use the shared managed wait subsystem for CoreCLR's managed code instead of the Win32 PAL

Also, remove the named mutex support from the CoreCLR PAL as nothing uses it now.

TODO: Once #117688 is in, we can remove Mutex support from the Win32 PAL entirely

Unblocks #115685

Depends on #117635

@jkoritzinsky jkoritzinsky added area-System.Threading runtime-coreclr specific to the CoreCLR runtime labels Jul 17, 2025
@jkoritzinsky jkoritzinsky mentioned this pull request Jul 17, 2025
Open
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@jkoritzinsky jkoritzinsky added this to the 11.0.0 milestone Jul 17, 2025
@jkoritzinsky jkoritzinsky added the blocked Issue/PR is blocked on something - see comments label Jul 17, 2025
@jkoritzinsky
Start working on porting shared mutexes to managed in a line-by-line …
f4625eb 
…port of the logic.
@jkoritzinsky
Fill out a lot of the rest of the logic.
1366d6b
@jkoritzinsky
Finish filling in the holes in the shared memory impl.
936dc6a
@jkoritzinsky
Fix process-level lock handling
b6d185a
@jkoritzinsky
Split into two files and fill out other entrypoints
2cae898
@jkoritzinsky
Move the named mutex impl to a runtime that has the wait subsystem.
3770ec6 
Create a NamedMutex class that wraps the underlying data structures
@jkoritzinsky
Finish integrating with the wait subsystem entry points and bring bac…
ca8eac2 
…k the "close" logic
@jkoritzinsky
Enable tests
563955e
@jkoritzinsky
Fix various problems found by tests and adjust locking to actually wo…
d6a29d1 
…rk and not deadlock
@jkoritzinsky
Adjust PThread setting default based on testing with our cross-build …
b82ddbf 
…images
@jkoritzinsky
Handle EOWNERDEAD
43f1c8d
@jkoritzinsky
Add stubs to wasi
8a06653
@jkoritzinsky
Don't use cross-process mutexes on mobile platforms. Only use the in-…
3a5a26c 
…proc model
@jkoritzinsky
Move the whole "shared data" struct for the pthread mutex impl across…
7d3540a 
… the managed->native veil.
@jkoritzinsky
Do a little cleanup
a2f4963
@jkoritzinsky
Remove unused member
7ea2c42
@jkoritzinsky
Cleanup projitems
e09b2be
@jkoritzinsky
Cleanup libraries pal a little
3ba1842
@jkoritzinsky
Rename and split out the "unsupported" impl
04e497d
@jkoritzinsky
Rename as requested
aac204b
@jkoritzinsky
Remove unused AcquirePthreadMutexWithTimeout impl
dcdfbd1
@jkoritzinsky
Fix failure on the "unsupported" path
2d3cd27
@jkoritzinsky
Add arg references.
d3d29a9
@jkoritzinsky jkoritzinsky force-pushed the coreclr-managed-wait branch from 25446d0 to 63dc9af Compare July 21, 2025 19:44
This was referenced Jul 22, 2025
Open
Open
Open
Open
Open
Open
Open
@build-analysis build-analysis bot mentioned this pull request Jul 23, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveisok steveisok Awaiting requested review from steveisok steveisok will be requested when the pull request is marked ready for review steveisok is a code owner

@vitek-karas vitek-karas Awaiting requested review from vitek-karas vitek-karas will be requested when the pull request is marked ready for review vitek-karas is a code owner

@lateralusX lateralusX Awaiting requested review from lateralusX lateralusX will be requested when the pull request is marked ready for review lateralusX is a code owner

@thaystg thaystg Awaiting requested review from thaystg thaystg will be requested when the pull request is marked ready for review thaystg is a code owner

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky will be requested when the pull request is marked ready for review MichalStrehovsky is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

@jkoritzinsky jkoritzinsky

Labels
area-System.Threading blocked Issue/PR is blocked on something - see comments runtime-coreclr specific to the CoreCLR runtime
Projects
None yet
Milestone
11.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@jkoritzinsky