Skip to content

Move CoreCLR over to the managed wait subsystem #117788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 42 commits into
base: main
Choose a base branch
from
Draft

Move CoreCLR over to the managed wait subsystem #117788

wants to merge 42 commits into from

Conversation

jkoritzinsky
Copy link
Member

@jkoritzinsky jkoritzinsky commented Jul 17, 2025 •
edited
Loading

Use the shared managed wait subsystem for CoreCLR's managed code instead of the Win32 PAL

Also, remove the named mutex support from the CoreCLR PAL as nothing uses it now.

TODO: Once #117688 is in, we can remove Mutex support from the Win32 PAL entirely

Unblocks #115685

Depends on #117635

@jkoritzinsky jkoritzinsky added area-System.Threading runtime-coreclr specific to the CoreCLR runtime labels Jul 17, 2025
@jkoritzinsky jkoritzinsky mentioned this pull request Jul 17, 2025
Open
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@jkoritzinsky jkoritzinsky added this to the 11.0.0 milestone Jul 17, 2025
@jkoritzinsky jkoritzinsky added the blocked Issue/PR is blocked on something - see comments label Jul 17, 2025
@jkoritzinsky jkoritzinsky force-pushed the coreclr-managed-wait branch from 25446d0 to 63dc9af Compare July 21, 2025 19:44
This was referenced Jul 22, 2025
Open
Open
Open
Open
Open
Open
Closed
Open
@jkoritzinsky
Start working on porting shared mutexes to managed in a line-by-line …
02db598 
…port of the logic.
@jkoritzinsky
Fill out a lot of the rest of the logic.
b855928
@jkoritzinsky
Finish filling in the holes in the shared memory impl.
9ec79b8
@jkoritzinsky
Fix process-level lock handling
74d6db7
@jkoritzinsky
Split into two files and fill out other entrypoints
ab7b688
@jkoritzinsky
Move the named mutex impl to a runtime that has the wait subsystem.
5c59aad 
Create a NamedMutex class that wraps the underlying data structures
@jkoritzinsky
Finish integrating with the wait subsystem entry points and bring bac…
40ec2d7 
…k the "close" logic
@jkoritzinsky
Enable tests
4904eb7
@jkoritzinsky
Fix various problems found by tests and adjust locking to actually wo…
194ea40 
…rk and not deadlock
@jkoritzinsky
Adjust PThread setting default based on testing with our cross-build …
6495e44 
…images
@jkoritzinsky
Handle EOWNERDEAD
189a71e
@jkoritzinsky
Add stubs to wasi
7cfb931
@jkoritzinsky
Don't use cross-process mutexes on mobile platforms. Only use the in-…
69fe72f 
…proc model
@jkoritzinsky
Move the whole "shared data" struct for the pthread mutex impl across…
ee0f7ce 
… the managed->native veil.
jkoritzinsky and others added 27 commits July 29, 2025 20:32
@jkoritzinsky
Do a little cleanup
9787f15
@jkoritzinsky
Remove unused member
bce3af6
@jkoritzinsky
Cleanup projitems
36bd5c0
@jkoritzinsky
Cleanup libraries pal a little
182c57a
@jkoritzinsky
Rename and split out the "unsupported" impl
61aabd4
@jkoritzinsky
Rename as requested
ba0ecc2
@jkoritzinsky
Remove unused AcquirePthreadMutexWithTimeout impl
a2d9121
@jkoritzinsky
Fix failure on the "unsupported" path
0cfacc1
@jkoritzinsky
Add arg references.
5cbaa62
@jkoritzinsky
Use the correct API for locking with a specific clock.
05cecb6
@jkoritzinsky
Mark noreturn for debug builds to satisfy compiler
e4d595d
@jkoritzinsky
Allow abandonment from the finalizer thread. Sometimes we can only cl…
d1dca10 
…ean up a thread's managed logic from the finalizer thread.
@jkoritzinsky
Add timeout for one test that was missing it. Fix named mutex tests o…
1c7c39d 
…n Mono
@jkoritzinsky
Fix CoreCLR and NAOT builds
e23ccc5
@jkoritzinsky
Refactor how named mutex ownership is tracked for abandonment to make…
510efcf 
… it more trimmable
@jkoritzinsky
Update comsynchronizable.cpp
895af9e
@jkoritzinsky
Use a Mutex for process-level locking in the no-pthreads implementati…
4e80270 
…on. Its the only primitive that supports abandoment correctly.
@jkoritzinsky
PR feedback
79c7812
@jkoritzinsky
Do a little bit of cleanup on formatting
625b8d6
@jkoritzinsky
Use the wait subsystem on CoreCLR on Unix platforms.
507ba1f
@jkoritzinsky
Remove wait subsystem qcall entrypoints
193be00
@jkoritzinsky
Remove named mutex support from the CoreCLR PAL
90be37b
@jkoritzinsky
Fix qcalls and managed/native sizes
2b209c6
@jkoritzinsky
Unify LowLevelLifoSemaphore implementations for Unix to use the wait …
79b75ed 
…subsystem
@jkoritzinsky
Hook up the "thread exiting" callback
5f07dbc
@jkoritzinsky
Delete Mutex support from the PAL
00ac1f8
@jkoritzinsky
Remove concept of ownership and abandonment and other vistigial compo…
934179a 
…nents of mutexes from the CoreCLR PAL.
@jkoritzinsky jkoritzinsky force-pushed the coreclr-managed-wait branch from bf32f50 to 934179a Compare July 29, 2025 21:34
@jkoritzinsky jkoritzinsky force-pushed the coreclr-managed-wait branch from 1e7ebc1 to 06de3b2 Compare July 29, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveisok steveisok Awaiting requested review from steveisok steveisok will be requested when the pull request is marked ready for review steveisok is a code owner

@vitek-karas vitek-karas Awaiting requested review from vitek-karas vitek-karas will be requested when the pull request is marked ready for review vitek-karas is a code owner

@lateralusX lateralusX Awaiting requested review from lateralusX lateralusX will be requested when the pull request is marked ready for review lateralusX is a code owner

@thaystg thaystg Awaiting requested review from thaystg thaystg will be requested when the pull request is marked ready for review thaystg is a code owner

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky will be requested when the pull request is marked ready for review MichalStrehovsky is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

@jkoritzinsky jkoritzinsky

Labels
area-System.Threading blocked Issue/PR is blocked on something - see comments runtime-coreclr specific to the CoreCLR runtime
Projects
None yet
Milestone
11.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@jkoritzinsky