Implement Unsafe.IsAddressLessThanOrEqualTo & Unsafe.IsAddressGreaterThanOrEqualTo
#117800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rThanOrEqualTo Copied from dotnet#89156 (@stephentoub wrote it), but without mono intrinsicification
github-actions
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
Revert unintentional whitespace changes
Revert unintentional whitespace changes
jkotas
reviewed
Jul 18, 2025
This was referenced Jul 18, 2025
MihaZupan
added
area-System.Runtime.CompilerServices
and removed
needs-area-label
jkotas
reviewed
Jul 25, 2025
src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/Unsafe.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jul 25, 2025
src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/Unsafe.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jul 25, 2025
jkotas
reviewed
Jul 25, 2025
jkotas
reviewed
Jul 25, 2025
jkotas
reviewed
Jul 25, 2025
Is the Mono JIT/interpreter able to inline this so that there is no perf regression on Mono? |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Jul 26, 2025
This was referenced Jul 26, 2025
jkotas
reviewed
Jul 26, 2025
src/coreclr/tools/Common/TypeSystem/IL/Stubs/UnsafeIntrinsics.cs
Outdated
Show resolved
Hide resolved
src/coreclr/tools/Common/TypeSystem/IL/Stubs/UnsafeIntrinsics.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Collections.Immutable/tests/Frozen/FrozenFromKnownValuesTests.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jul 26, 2025
src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/Unsafe.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jul 26, 2025
src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/Unsafe.cs
Outdated
Show resolved
Hide resolved
This was referenced Jul 27, 2025
|
/ba-g infrastructure timeouts |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88478
Based on @stephentoub's #89156, but excluding the mono intrinsicification
/cc @tannergooding