Unify asserts in the interpexec.cpp #121213
Open
+12
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a mix of using `assert` and `_ASSERTE` in this file. The `assert` is a pain for local testing on Windows, as it pops out a dialog box when the assert fires. This change unifies all of them to `_ASSERTE`.
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
There was a problem hiding this comment.
Pull Request Overview
This PR unifies assertion macros in the interpexec.cpp file by replacing all instances of assert with _ASSERTE to improve the Windows development experience by avoiding dialog popups during local testing.
- Replaced 12 instances of
assertwith_ASSERTEthroughout the file - Maintained identical assertion logic and conditions
- Improved debugging experience for Windows developers
kg
approved these changes
Oct 30, 2025
kg
reviewed
Oct 30, 2025
| break; | ||
| default: | ||
| assert(!"Unimplemented or invalid interpreter opcode"); | ||
| _ASSERTE(!"Unimplemented or invalid interpreter opcode"); |
There was a problem hiding this comment.
This should probably be something other than asserte, it's not recoverable and should be a failure even in release builds
There was a problem hiding this comment.
You are right, this should rather be a fail fast, as it it unrecoverable.
Open
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a mix of using
assertand_ASSERTEin this file. Theassertis a pain for local testing on Windows, as it pops out a dialog box when the assert fires.This change unifies all of them to
_ASSERTE.