Re-enable DotNet.Watcher.Tests #49642
Conversation
|
@tmat, are we allowed to use Task.Delay() method in test case to enhance the stability of test case? |
|
@SimonZhao888 Please, no task delays. |
SimonZhao888
added
the
Area-Containers
There was a problem hiding this comment.
Pull Request Overview
This PR re-enables previously skipped tests in the DotNet.Watcher.Tests project by removing the Skip parameter that was referencing issue #42921. The tests were temporarily disabled and are now being brought back into the active test suite.
- Removes Skip attributes from two test methods that were disabled due to issue #42921
- Re-enables
ChangeCompiledFileandChangeExcludedFiletests in the globbing app test suite
| @@ -12,7 +12,7 @@ public GlobbingAppTests(ITestOutputHelper logger) | |||
| { | |||
| } | |||
|
|
|||
| [ConditionalTheory(Skip = "https://github.com/dotnet/sdk/issues/42921")] | |||
| [ConditionalTheory] | |||
There was a problem hiding this comment.
Re-enabling this test should include verification that the underlying issue #42921 has been resolved. Consider adding a comment explaining why the test is now safe to re-enable or what changes fixed the original problem.
Copilot generated this review using guidance from copilot-instructions.md.
| @@ -85,7 +85,7 @@ public async Task RenameCompiledFile() | |||
| await App.AssertStarted(); | |||
| } | |||
|
|
|||
| [Fact(Skip = "https://github.com/dotnet/sdk/issues/42921")] | |||
| [Fact] | |||
There was a problem hiding this comment.
Re-enabling this test should include verification that the underlying issue #42921 has been resolved. Consider adding a comment explaining why the test is now safe to re-enable or what changes fixed the original problem.
Copilot generated this review using guidance from copilot-instructions.md.
SimonZhao888
added
Test Debt
and removed
Area-Containers
#42921