Handle versioned #:sdk being first
#49807
Open
+69
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 16, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue 49797 by ensuring versioned #:sdk directives at the top of a C# script are handled correctly for both dotnet run and dotnet project convert.
- Added
SdkReference_VersionedSdkFirsttest inRunFileTests.cs - Added
Directives_VersionedSdkFirsttest inDotnetProjectConvertTests.cs - Updated
VirtualProjectBuildingCommandto split SDK name and version, adjust imports, and remove the oldToSlashDelimitedStringmethod
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/dotnet.Tests/CommandTests/Run/RunFileTests.cs | New fact validating build when a versioned #:sdk is first |
| test/dotnet.Tests/CommandTests/Project/Convert/...ConvertTests.cs | New fact validating conversion when a versioned #:sdk is first |
| src/Cli/dotnet/Commands/Run/VirtualProjectBuildingCommand.cs | Logic to correctly handle first versioned SDK directive and adjust import statements |
MiYanni
approved these changes
Jul 17, 2025
|
@RikkiGibson @jaredpar please review a small but important bugfix, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49797.