Ensure all evaluation data are in binlogs from file-based apps #49841
+14
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjonescz
force-pushed
the
sprint-binlog-eval-2
branch
from
662e468 to
a13354b
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that both restore and build evaluation data are properly captured in binary logs for file-based applications. Previously, only restore evaluation data was being logged to binlogs, missing build evaluation data.
- Restructures project creation to occur before
BeginBuild()is called to ensure evaluation data is captured - Updates test assertions to verify exactly 2 evaluation events (restore + build) instead of just checking for existence
- Removes conditional
BeginBuild()calls and consolidates to a single call after project creation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Cli/dotnet/Commands/Run/VirtualProjectBuildingCommand.cs | Restructures project creation and build initialization to ensure evaluation data is captured in binlogs |
| test/dotnet.Tests/CommandTests/Run/RunFileTests.cs | Updates test to verify exactly 2 evaluation events are logged |
MiYanni
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better fix than #49588.
Currently only restore evaluation data are in the binlogs, not build evaluation data - this PR fixes that.