Skip to content

Remove unnecessary license and xml headers #49963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ViktorHofer
Copy link
Member

The license header is only needed in shipping content files. It explicitly isn't needed in input files.

The license header is only needed in shipping content files. It explicitly isn't needed in input files.
@Copilot Copilot AI review requested due to automatic review settings July 28, 2025 08:34
@ViktorHofer ViktorHofer requested review from tmat and a team as code owners July 28, 2025 08:34
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes unnecessary license headers and XML version declarations from test files and internal build configuration files. The license header is only required in shipping content files according to the project's guidelines, and these input/test files don't need the overhead.

Key changes:

  • Removed MIT license headers from test project files and build configuration files
  • Removed XML version declarations where not needed
  • Added whitespace formatting for improved readability

Reviewed Changes

Copilot reviewed 37 out of 37 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/dotnet-watch.Tests/Directory.Build.targets Removed license header
test/dotnet-new.IntegrationTests/TestDirectoryBuildFiles/Directory.Build.targets Removed XML declaration and license header, simplified to self-closing Project tag
test/dotnet-new.IntegrationTests/TestDirectoryBuildFiles/Directory.Build.props Removed XML declaration and license header, added whitespace
test/Microsoft.NET.ToolPack.Tests/Microsoft.NET.ToolPack.Tests.csproj Removed XML declaration and license header
test/Microsoft.NET.TestFramework/SetupTestRoot.targets Removed license header
test/Microsoft.NET.TestFramework/Microsoft.NET.TestFramework.csproj Removed XML declaration and license header
test/Microsoft.NET.Sdk.StaticWebAssets.Tests/content/ExternalStaticAssets.targets Removed XML declaration, simplified Project tag, added whitespace
test/Microsoft.NET.Sdk.Razor.Tool.Tests/Microsoft.NET.Sdk.Razor.Tool.Tests.csproj Removed XML declaration and license header
test/Microsoft.NET.Sdk.Razor.Tests/content/ExternalStaticAssets.targets Removed XML declaration, simplified Project tag, added whitespace
test/Microsoft.NET.Restore.Tests/Microsoft.NET.Restore.Tests.csproj Removed XML declaration and license header
test/Microsoft.NET.Rebuild.Tests/Microsoft.NET.Rebuild.Tests.csproj Removed XML declaration and license header
test/Microsoft.NET.Clean.Tests/Microsoft.NET.Clean.Tests.csproj Removed XML declaration and license header, added whitespace
test/Microsoft.NET.Build.Tests/Microsoft.NET.Build.Tests.csproj Removed XML declaration and license header, added whitespace
test/Directory.Build.targets Removed license header
test/Common/Empty.targets Removed XML declaration and license header, added whitespace
test/Common/Empty.props Removed XML declaration and license header, added whitespace
src/Tasks/Microsoft.NET.Build.Tasks.UnitTests/Microsoft.NET.Build.Tasks.UnitTests.csproj Removed XML declaration and license header
src/Tasks/Microsoft.NET.Build.Extensions.Tasks/Microsoft.NET.Build.Extensions.Tasks.csproj Removed XML declaration and license header
src/Tasks/Microsoft.NET.Build.Extensions.Tasks.UnitTests/Microsoft.NET.Build.Extensions.Tasks.UnitTests.csproj Removed XML declaration and license header
src/Layout/redist/targets/GenerateMSIs.targets Removed license header, added whitespace
src/Layout/pkg/windows/msis/toolset/toolset.wixproj Removed license header, added whitespace
src/Layout/pkg/windows/msis/toolset/product.wxs Removed license header
src/Layout/pkg/windows/msis/templates/templates.wixproj Removed license header, added whitespace
src/Layout/pkg/windows/msis/templates/product.wxs Removed license header
src/Layout/pkg/windows/msis/registrykeys.wxs Removed license header
src/Layout/pkg/windows/msis/placeholder/product.wxs Removed license header
src/Layout/pkg/windows/msis/placeholder/placeholder.wixproj Removed license header, added whitespace
src/Layout/pkg/windows/msis/directories.wxs Removed license header
src/Layout/pkg/windows/msis/Directory.Build.props Removed license header, added whitespace
src/Layout/pkg/windows/bundles/sdk/bundle.wxs Removed license header
src/Layout/pkg/windows/bundles/sdk/bundle.wixproj Removed license header
src/Layout/pkg/windows/bundles/sdk/bundle.thm Removed license header
src/Layout/pkg/windows/Directory.Build.targets Removed license header, added whitespace
src/Layout/pkg/windows/Directory.Build.props Removed license header, added whitespace, removed extra closing PropertyGroup tag
OverrideTest.targets Removed XML declaration and license header, reformatted Target element for better readability
Directory.Build.targets Removed XML declaration and license header, added whitespace
Directory.Build.props Removed license header
Comments suppressed due to low confidence (1)

Copy link
Member

@MiYanni MiYanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup! :shipit:

Copy link
Member

@marcpopMSFT marcpopMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting a hold on this as we want to confirm with CELA on this. In particular, how are the wxl files different than a .cs file that compiles into a binary. It makes sense for the various targets files we have for our own build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants