Skip to content

Conversation

@tmat
Copy link
Member

@tmat tmat commented Aug 28, 2025

Port #49611 and #49974 from main

Copilot AI review requested due to automatic review settings August 28, 2025 19:44
@tmat tmat requested review from a team as code owners August 28, 2025 19:44
@github-actions
Copy link
Contributor

This PR is targeting main, which is now for .NET 11-facing work. If you intended to target .NET 10, either retarget this PR to release/10.0.1xx or make sure you backport the change to release/10.0.1xx after merging. See #50394 for more details.

@github-actions github-actions bot added the Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch label Aug 28, 2025
@tmat tmat changed the base branch from main to release/10.0.1xx August 28, 2025 19:44
@dotnet-policy-service
Copy link
Contributor

Thanks for your PR, @@tmat.
To learn about the PR process and branching schedule of this repo, please take a look at the SDK PR Guide.

@tmat
Copy link
Member Author

tmat commented Aug 28, 2025

@DustinCampbell @phil-allen-msft ptal.

This comment was marked as outdated.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request ports Hot Reload changes from main to align the test infrastructure with the main branch implementation. The changes primarily focus on modernizing the logging and reporting architecture by migrating from a custom IReporter interface to the standard Microsoft.Extensions.Logging framework.

Key Changes:

  • Replace custom IReporter interface with ILogger and ILoggerFactory from Microsoft.Extensions.Logging
  • Update test utilities to use the new logging infrastructure while maintaining backward compatibility for testing
  • Modernize message descriptors and error handling patterns

Reviewed Changes

Copilot reviewed 109 out of 109 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
test/dotnet-watch.Tests/Watch/*.cs Updated test context creation to use new logging infrastructure
test/dotnet-watch.Tests/TestUtilities/*.cs Migrated test utilities from reporter-based to logger-based patterns
test/dotnet-watch.Tests/HotReload/*.cs Updated Hot Reload tests to use new API methods and message patterns
src/BuiltInTools/dotnet-watch/UI/*.cs Replaced IReporter with ILogger and modernized message handling
src/BuiltInTools/dotnet-watch/Process/*.cs Updated process management to use structured logging
src/BuiltInTools/dotnet-watch/HotReload/*.cs Migrated Hot Reload components to use ILogger

@dbreshears dbreshears self-requested a review August 30, 2025 00:06
@tmat tmat merged commit 099eec4 into dotnet:release/10.0.1xx Aug 30, 2025
27 checks passed
@tmat tmat deleted the PortClient branch August 30, 2025 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants