- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.2k
Port Hot Reload changes from main #50534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| This PR is targeting  | 
| Thanks for your PR, @@tmat. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request ports Hot Reload changes from main to align the test infrastructure with the main branch implementation. The changes primarily focus on modernizing the logging and reporting architecture by migrating from a custom IReporter interface to the standard Microsoft.Extensions.Logging framework.
Key Changes:
- Replace custom IReporterinterface withILoggerandILoggerFactoryfrom Microsoft.Extensions.Logging
- Update test utilities to use the new logging infrastructure while maintaining backward compatibility for testing
- Modernize message descriptors and error handling patterns
Reviewed Changes
Copilot reviewed 109 out of 109 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description | 
|---|---|
| test/dotnet-watch.Tests/Watch/*.cs | Updated test context creation to use new logging infrastructure | 
| test/dotnet-watch.Tests/TestUtilities/*.cs | Migrated test utilities from reporter-based to logger-based patterns | 
| test/dotnet-watch.Tests/HotReload/*.cs | Updated Hot Reload tests to use new API methods and message patterns | 
| src/BuiltInTools/dotnet-watch/UI/*.cs | Replaced IReporter with ILogger and modernized message handling | 
| src/BuiltInTools/dotnet-watch/Process/*.cs | Updated process management to use structured logging | 
| src/BuiltInTools/dotnet-watch/HotReload/*.cs | Migrated Hot Reload components to use ILogger | 
Port #49611 and #49974 from main