Add ArtifactsPath to SourceRoot for deterministic builds outside repo - #52093
marcpopMSFT with Copilot wants to merge 3 commits into
Conversation
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
40eff34 to
017fe4c
Compare
|
@tmat I believe you know source link well so may know if this is the right solution here. I just had copilot follow what the original issue stated but wanted someone to confirm. |
|
@copilot there are merge conflicts with origin/main. Can you merge that in and fix the conflicts? |
Resolved conflicts in test file by keeping both sets of tests: - Tests from main that verify SourceRoot using GetValuesCommand - Additional test for external ArtifactsPath scenario
|
@marcpopMSFT I think I actually got this fixed in a separate issue report + PR last week. Yeah, it was in #52640 - there's also a Roslyn PR coming so that Roslyn does path abolutization as part of this effort as well. |
Merged origin/main and resolved conflicts in commit 3cef343. The conflict was in the test file where main added two tests ( |
|
Looks indeed like you already took care of this, closing. |
Implementation Plan
Summary
Successfully merged origin/main into the PR branch and resolved conflicts in the test file. The merge preserved:
The implementation adds ArtifactsPath to SourceRoot items in Microsoft.NET.DefaultOutputPaths.targets, ensuring proper source mapping for deterministic builds when artifacts are outside the repository root.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.