Skip to content

Indeterminate and checked ToolStripMenuItem icons are now clearly visible in dark mode on ContextMenuStrip, MenuStrip, StatusStrip and ToolStrip drop-down buttons. #14317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ricardobossan wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Indeterminate and checked ToolStripMenuItem icons are now clearly visible in dark mode on ContextMenuStrip, MenuStrip, StatusStrip and ToolStrip drop-down buttons. #14317

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98ec7f7
Fixes #11933
Feb 20, 2026
312455d
Addresses feedback
Feb 25, 2026
b09d495
Handles feedback
Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 29 additions & 6 deletions src/System.Windows.Forms/System/Windows/Forms/Controls/ToolStrips/ToolStripRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -856,27 +856,50 @@ protected virtual void OnRenderItemCheck(ToolStripItemImageRenderEventArgs e)
return;
}

// Track images we allocate so they can be disposed after drawing.
Image? disabledImage = null;
Image? invertedImage = null;

if (e.Item is not null)
{
if (!e.Item.Enabled)
{
image = CreateDisabledImage(image, e.ImageAttributes);
disabledImage = CreateDisabledImage(image, e.ImageAttributes);
image = disabledImage;
}

if (SystemInformation.HighContrast && image is Bitmap bitmap)
if (image is Bitmap bitmap)
{
Color backgroundColor = e.Item.Selected ? SystemColors.Highlight : e.Item.BackColor;
if (SystemInformation.HighContrast)
{
Color backgroundColor = e.Item.Selected ? SystemColors.Highlight : e.Item.BackColor;

if (ControlPaint.IsDark(backgroundColor))
if (ControlPaint.IsDark(backgroundColor))
{
invertedImage = ControlPaint.CreateBitmapWithInvertedForeColor(bitmap, e.Item.BackColor);
Copy link
Member

@LeafShi1 LeafShi1 Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To maintain logical consistency, the inversion here should use the same backgroundColor parameter as the conditional statement.

image = invertedImage;
}
}
else if (Application.IsDarkModeEnabled)
{
Image invertedImage = ControlPaint.CreateBitmapWithInvertedForeColor(bitmap, e.Item.BackColor);
image = invertedImage;
Color backgroundColor = e.Item.Selected ? SystemColors.Highlight : e.Item.BackColor;

if (ControlPaint.IsDark(backgroundColor))
{
// In dark mode, the check mark icons are dark glyphs designed for light
// backgrounds. Invert the foreground color so they are visible on dark backgrounds.
invertedImage = ControlPaint.CreateBitmapWithInvertedForeColor(bitmap, e.Item.BackColor);
image = invertedImage;
}
}
}
}

e.Graphics.DrawImage(image, imageRect, 0, 0, imageRect.Width,
imageRect.Height, GraphicsUnit.Pixel, e.ImageAttributes);

disabledImage?.Dispose();
invertedImage?.Dispose();
}

/// <summary>
Expand Down
Loading