Skip to content

Make Dependent implement IEquatable<T> to reduce boxing #11179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Make Dependent implement IEquatable<T> to reduce boxing #11179

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07680d4
Make Dependent implement IEquatable<T> to reduce boxing
IAmTheCShark Oct 14, 2025
1f288f4
Compiler error
IAmTheCShark Oct 14, 2025
58a1db8
Update src/Microsoft.DotNet.Wpf/src/WindowsBase/System/Windows/Depend…
IAmTheCShark Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/Microsoft.DotNet.Wpf/src/WindowsBase/System/Windows/DependentList.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ private void CleanUpDeadWeakReferences()
}
}

internal struct Dependent
internal struct Dependent : IEquatable<Dependent>
{
private DependencyProperty _DP;
private WeakReference _wrDO;
Expand Down Expand Up @@ -178,14 +178,14 @@ public Expression Expr
return (Expression)_wrEX.Target;
}
}

public override bool Equals(object o)
{
if(! (o is Dependent))
return false;

Dependent d = (Dependent)o;

return o is Dependent d ? Equals(d) : false;
}
public bool Equals(Dependent d)
{
// Not equal to Dead values.
// This is assuming that at least one of the compared items is live.
// This assumtion comes from knowing that Equal is used by FrugalList.Remove()
Expand Down