Skip to content

Conversation

@rezigned
Copy link
Contributor

@rezigned rezigned commented Jun 22, 2023

When scrollback length is larger than visible rows. There're 2 issues that I've found.

Example config

let mut p = vt100::Parser::new(3, n, 10)
p.screen_mut().set_scrollback(6);

1. Extra rows returned
The .skip method will skip the first 4 (10 - 6 = 4) rows, thus it'll return 6 rows in total.
Even though we only want 3.

This is fixed by setting the upper bound via .take(rows_len).

2. Subtraction overflow
The .chain method will take additional rows via rows_len - offset i.e. 3 - 6 = overflow! We just need 0 rows.

This is fixed by using saturation.

Fix #4 #5

@rezigned rezigned changed the title Fix scrollback offset overflow Fix scrollback offset bugs Jun 22, 2023
chris-olszewski added a commit to vercel/turborepo that referenced this pull request Mar 6, 2024
### Description

Due to our use case we need to extend `vt100` with some functionality.
The functionality can be added upstream, but based on the age of PRs on
the project, we cannot wait for this to happen.

Reviewing instructions:
I quick documented changes I made from the straight `vt100` crate.
Significant behavior/bug fixes will be added in future PRs

General plans of changes:
- Cherry pick [underflow fix](doy/vt100-rust#11)
 - [Support dimmed formatting](doy/vt100-rust#9)
- Add a version of `Screen` that displays *all* content including lines
that are now in the scrollback
 - Some [perf fixes](doy/vt100-rust#14)

### Testing Instructions

Verified existing test suite passes on my machine. Verify test suite
passes on CI
chris-olszewski added a commit to vercel/turborepo that referenced this pull request Mar 26, 2024
### Description

Port of doy/vt100-rust#11

Should address part of #7843

### Testing Instructions

Unit tests, did quick spot check that this scrolling still works.


Closes TURBO-2700
@rezigned
Copy link
Contributor Author

Hi @doy, is there any chances that we can get this merged? Thank you.

@doy
Copy link
Owner

doy commented Jan 11, 2025

merged, thanks!

@doy doy closed this Jan 11, 2025
@doy doy mentioned this pull request Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants