Make effect-schema bufferSchema browser-safe#5462
Open
marbemac wants to merge 1 commit intodrizzle-team:betafrom
Open
Make effect-schema bufferSchema browser-safe#5462marbemac wants to merge 1 commit intodrizzle-team:betafrom
marbemac wants to merge 1 commit intodrizzle-team:betafrom
Conversation
Signed-off-by: Marc MacLeod <marbemac+gh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new
drizzle-orm/effect-schemapackage (added in beta.15) has the same browser compatibility issue that was previously fixed fordrizzle-arktypein #4424.In
effect-schema/column.ts:S.instanceOf(Buffer)evaluatesBuffereagerly at module load time. In browser environmentsBufferdoesn't exist, so importingdrizzle-orm/effect-schemacrashes immediately — even if none of your tables use buffer columns.Same class of issue as #4383. The other validator packages (zod, valibot) already avoid this because
zod.custom()/v.custom()wrap theinstanceofcheck in a callback. The arktype fix in #4424 did the same thing.Fix
Uses
S.declarewith a type guard soBufferis only referenced when the schema is actually used for validation, not at module load. Same runtime behavior, just deferred.