fix(mariadb): use CHANGE instead of RENAME COLUMN for column renaming#5507
Open
buyuan-dev wants to merge 1 commit intodrizzle-team:mainfrom
Open
fix(mariadb): use CHANGE instead of RENAME COLUMN for column renaming#5507buyuan-dev wants to merge 1 commit intodrizzle-team:mainfrom
buyuan-dev wants to merge 1 commit intodrizzle-team:mainfrom
Conversation
Fixes drizzle-team#5404 MariaDB doesn't support the standard SQL 'ALTER TABLE ... RENAME COLUMN' syntax. Instead, it requires 'ALTER TABLE ... CHANGE old_name new_name data_type' syntax. The fix detects MariaDB dialect and generates the appropriate CHANGE syntax for column renaming operations, which is compatible with both MySQL and MariaDB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where column renaming in MariaDB generated invalid SQL syntax.
Problem
MariaDB doesn't support the standard SQL \ALTER TABLE ... RENAME COLUMN\ syntax. When drizzle-kit generated this syntax for MariaDB, migrations would fail with a syntax error:
\
You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'COLUMN \Name\ TO \Description' at line 1
\\
Fix
Changed the MySQL dialect to use \ALTER TABLE ... CHANGE old_name new_name data_type\ syntax instead of \RENAME COLUMN. The CHANGE syntax is compatible with both MySQL and MariaDB.
Before:
\\sql
ALTER TABLE \Status\ RENAME COLUMN \Name\ TO \Description;
\\
After:
\\sql
ALTER TABLE \Status\ CHANGE \Name\ \Description\ varchar(30) NOT NULL;
\\
Testing
Fixes #5404