fix(valibot): Array columns type inference in valibot schema#5530
Open
ZatTwilight wants to merge 1 commit intodrizzle-team:betafrom
Open
fix(valibot): Array columns type inference in valibot schema#5530ZatTwilight wants to merge 1 commit intodrizzle-team:betafrom
ZatTwilight wants to merge 1 commit intodrizzle-team:betafrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixing the inferred type of array columns for generated valibot schemas.
Currently a generated schema type will just provide the base type of the column. i.e.
text("my_array").array()would just have a type ofstringrather thanstring[].This limits its usability where the validator is used to validate data and then also infer the type from that hence providing the wrong type to typescript despite having the correct array validator.
This should hopefully align with the zod and arktype methods for determining and returning array types.