feat: add timestamp_columns config option
#173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbernays
force-pushed
the
timestamp_columns_option
branch
from
926159e to
7e0c686
Compare
|
Just noting that I did see this PR (just now). I know these changes are also in in #174 which is perfectly fine. Let me know if you want to approve and merge independently, otherwise I'll continue to discuss in the other PR. |
pbernays
force-pushed
the
timestamp_columns_option
branch
from
7e0c686 to
a8b1214
Compare
|
I'd prefer this one was independent. It's only in the other PR because I messed up organising my branches. The other PR was and is intended to be food-for-thought, and probably something that needs more TLC before it gets merged while I try to align with your goals. |
drwl
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working with a codebase that doesn't use Rails' default timestamp columns, so being able to customise those would be helpful. This adds
timestamp_columnsas a configurable option for classified sorting, and sorts them in config order rather than alphabetical order.