Update install-wrapped.sh #107
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Line 52 echoes DGPATH into wrapper scripts. When built in a sandbox, this breaks the dgsh programs after they have been moved out of the temporary build directory. Changed to fix.
|
Thank you! Could you perhaps look into the failing CI build? It could be irrelevant to your change, but I'd like to pull your change with a clean CI build. |
|
I looked at the log and I wasn't really sure what was causing the error. |
|
Maybe a flakey test. I'm rerunning it. |
|
Are there any tests run inside the temporary install directory? This may have changed it from being broken while outside the temporary directory to being broken while inside the temporary directory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line 52 echoes DESTDIR into wrapper scripts. When built in a sandbox, this breaks the dgsh programs after they have been moved out of the temporary install directory. Changed to fix.