Skip to content

Change omnibar icon based on input suffix #1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

noisysocks
Copy link
Contributor

@noisysocks noisysocks commented Jul 23, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1209121419454298/task/1210867372767327

Description

This PR updates the omnibar widget in the new tab page to change the icon on the left of the SearchForm's input. The icon will now display a globe (🌐) instead of a search icon (🔍) when the input suffix has kind = "visit".

This provides a clearer visual indicator to users that their input will result in navigating to a website (e.g., typing a URL, selecting a website suggestion) rather than performing a search.

Testing Steps

https://deploy-preview-1844--content-scope-scripts.netlify.app/build/pages/new-tab/?omnibar=true

  • Open the New Tab Page.
  • To see the globe icon:
    • Type a URL-like string (e.g., example.com, https://duckduckgo.com).
    • Select a suggestion that leads to a website visit (e.g., a "website" suggestion, a bookmark, or history entry).
  • To see the search icon:
    • Type a regular search query (e.g., weather, how to bake a cake).

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Open in WebOpen in Cursor

@noisysocks noisysocks requested review from shakyShane, mgurgel and a team as code owners July 23, 2025 11:13
Copy link

github-actions bot commented Jul 23, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Jul 23, 2025

[Beta] Generated file diff

Time updated: Thu, 24 Jul 2025 08:33:00 GMT

Integration
    - integration/pages/new-tab/dist/index.js

File has changed

Windows
    - windows/pages/new-tab/dist/index.js

File has changed

Apple
    - dist/pages/new-tab/dist/index.js

File has changed

Copy link

netlify bot commented Jul 23, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit f0487cf
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/6881ef844c69af0008fee899
😎 Deploy Preview https://deploy-preview-1844--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@noisysocks noisysocks added the bug Something isn't working label Jul 23, 2025
@noisysocks
Copy link
Contributor Author

Code looks right but the icon wiggles around when it changes. Will do this manually tomorrow.

@noisysocks noisysocks marked this pull request as draft July 23, 2025 11:17
@noisysocks noisysocks marked this pull request as ready for review July 24, 2025 01:19
@noisysocks
Copy link
Contributor Author

Merging main fixed it. Testing well now 👍

@noisysocks noisysocks merged commit 0f0258c into main Jul 24, 2025
15 checks passed
@noisysocks noisysocks deleted the cursor/change-omnibar-icon-based-on-input-suffix-893a branch July 24, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants