Skip to content

NTP: Fix input styling on Windows #1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 30, 2025

Conversation

noisysocks
Copy link
Contributor

@noisysocks noisysocks commented Jul 29, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1209121419454298/task/1210872043151933?focus=true

Description

Two Windows specific fixes:

  1. Style input and textarea selection colour to match how it looks in Windows browser.
  2. Reduce font weight (which I bumped in Update omnibar widget design and copy #1843) on Windows where its address bar uses 400 instead of 500.

I’m also putting the font into a CSS variable to prevent an easy-to-make mistake where you update the font in the CSS but forget about measureText.

Testing Steps

https://deploy-preview-1862--content-scope-scripts.netlify.app/build/pages/new-tab/?omnibar=true

Test the Search tab and Duck.ai tabs in DuckDuckGo on Windows and macOS. Ensure that the text in both inputs matches what’s in the address bar. Ensure that the selected text in both inputs matches selected text in the address bar.

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@noisysocks noisysocks added the bug Something isn't working label Jul 29, 2025
@noisysocks noisysocks requested review from shakyShane, mgurgel and a team as code owners July 29, 2025 23:36
Copy link

netlify bot commented Jul 29, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 85f6c5f
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/6889f4385431220008080236
😎 Deploy Preview https://deploy-preview-1862--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

github-actions bot commented Jul 29, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Jul 29, 2025

[Beta] Generated file diff

Time updated: Wed, 30 Jul 2025 10:31:21 GMT

Apple
    - apple/pages/new-tab/dist/index.css
  • apple/pages/new-tab/dist/index.js

File has changed

Integration
    - integration/pages/new-tab/dist/index.css
  • integration/pages/new-tab/dist/index.js

File has changed

Windows
    - windows/pages/new-tab/dist/index.css
  • windows/pages/new-tab/dist/index.js

File has changed

cursor[bot]

This comment was marked as outdated.

@noisysocks noisysocks merged commit 621556e into main Jul 30, 2025
15 checks passed
@noisysocks noisysocks deleted the randerson/fix-omnibar-windows-input-styling branch July 30, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants