Skip to content

Conversation

dbajpeyi
Copy link
Contributor

@dbajpeyi dbajpeyi commented Sep 3, 2025

Asana Task/Github Issue:
https://app.asana.com/1/137249556945/project/481882893211075/task/1211159060891805?focus=true

Description

This PR allows automation of google takeout flow, using DBP/PIR APIs.

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Note

Implements Android bookmark import via new autofillImport feature with generic retry and shared action executor; adds scroll action and updates builds/tests/configs from autofill-password-import to autofill-import.

  • Features:
    • AutofillImport: New feature (injected/src/features/autofill-import.js) to automate Google Takeout bookmark flow.
      • Handles location-based routing, element animation/tap, export-id capture, download URL construction, and Android messaging notifications.
      • Uses new withRetry and shared ActionExecutorBase for action processing and retries.
  • Broker Protection:
    • Extracts ActionExecutorBase to share action processing/notification with AutofillImport.
    • Adds new scroll action (wired into executor and types).
  • Utils:
    • Replaces withExponentialBackoff with generalized withRetry (supports linear/exponential strategies).
  • Build/Config:
    • Introduces android-autofill-import build target (new entry point/output); updates features.js to autofillImport.
    • Updates globals/types to include new inject name and action type.
  • Tests:
    • Renames and updates Playwright specs, configs, and helpers from autofill-password-import to autofill-import; adds test config under integration-test/test-pages/autofill-import/.
  • Ownership:
    • CODEOWNERS path updated to injected/src/features/autofill-import.js.

Written by Cursor Bugbot for commit 1ced8d1. This will update automatically on new commits. Configure here.

Copy link

netlify bot commented Sep 3, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 1ced8d1
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/68da63be7b09bd0008d3c581
😎 Deploy Preview https://deploy-preview-1935--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

github-actions bot commented Sep 3, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Sep 3, 2025

[Beta] Generated file diff

Time updated: Mon, 29 Sep 2025 10:48:12 GMT

Android
    - android/adsjsContentScope.js
  • android/brokerProtection.js
  • android/contentScope.js

File has changed

Removed Files
    - android/autofillPasswordImport.js

❌ File only exists in old changeset

Apple
    - apple/contentScope.js
  • apple/contentScopeIsolated.js

File has changed

Chrome-mv3
    - chrome-mv3/inject.js

File has changed

Firefox
    - firefox/inject.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

New Files
    - android/autofillImport.js

❌ File only exists in new changeset

@dbajpeyi dbajpeyi force-pushed the dbajpeyi/hack/autofill-bookmark-import branch from 9109dde to fcdefe5 Compare September 5, 2025 11:19
@dbajpeyi dbajpeyi force-pushed the dbajpeyi/hack/autofill-bookmark-import branch from 5a94b61 to f2529f1 Compare September 12, 2025 18:18
@dbajpeyi dbajpeyi force-pushed the dbajpeyi/hack/autofill-bookmark-import branch from f2529f1 to 86cf6c2 Compare September 12, 2025 18:18
* Use DBP for running execution
@dbajpeyi dbajpeyi marked this pull request as ready for review September 17, 2025 18:27
@dbajpeyi dbajpeyi requested review from a team as code owners September 17, 2025 18:27
@dbajpeyi dbajpeyi force-pushed the dbajpeyi/hack/autofill-bookmark-import branch from 6afeb1b to 1dc1b6a Compare September 17, 2025 18:28
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@dbajpeyi dbajpeyi changed the title separate password and bookmark flow [Google Takeout Automation] Bookmark import on Android Sep 17, 2025
@dbajpeyi dbajpeyi force-pushed the dbajpeyi/hack/autofill-bookmark-import branch 2 times, most recently from 46793a8 to d121bc7 Compare September 17, 2025 18:48
@dbajpeyi dbajpeyi force-pushed the dbajpeyi/hack/autofill-bookmark-import branch from d121bc7 to 44424cd Compare September 17, 2025 18:53
@dbajpeyi dbajpeyi force-pushed the dbajpeyi/hack/autofill-bookmark-import branch from b7c3347 to c481311 Compare September 24, 2025 12:37
Copy link
Contributor

@jonathanKingston jonathanKingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block on dbp folk being ok with this change. But otherwise I’m good here. I left a bunch of comments that I’m happy to be fast follow.

@dbajpeyi dbajpeyi requested a review from madblex September 25, 2025 08:21
@dbajpeyi dbajpeyi removed the request for review from hanyutang-sandra September 29, 2025 11:07
@dbajpeyi dbajpeyi added this pull request to the merge queue Sep 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 29, 2025
@dbajpeyi dbajpeyi added this pull request to the merge queue Sep 29, 2025
Merged via the queue into main with commit 8e0a9fc Sep 29, 2025
21 checks passed
@dbajpeyi dbajpeyi deleted the dbajpeyi/hack/autofill-bookmark-import branch September 29, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants