[Matching] Allow 'ignore' as inputtype #766
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbajpeyi
changed the title
dbajpeyi
commented
Mar 4, 2025
dbajpeyi
force-pushed
the
dbajpeyi/feat/add-ignore-inputtype
branch
from
e2d443c to
e2fb010
Compare
dbajpeyi
force-pushed
the
dbajpeyi/feat/add-ignore-inputtype
branch
from
e2fb010 to
07b2984
Compare
|
@dbajpeyi Just a gentle nudge ☝️ do we still need this ignore inputtype? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @alistairjcbrown
Asana: https://app.asana.com/0/1199539352118559/1209563380559788
Description
We want to ability to
ignoreinputs that we intentionally don't want to be inferred. Adding a new intentional type calledignorethat gets checked ingetInputType, that will allow us to hardcode this. E.g on email protection signup, we don't want the email field to popup another email protection promo: