Skip to content

include app ver in reports - #78

Merged
ladamski merged 3 commits into
mainfrom
la/include-app-version-in-validation-reports
Jul 17, 2026
Merged

include app ver in reports#78
ladamski merged 3 commits into
mainfrom
la/include-app-version-in-validation-reports

Conversation

@ladamski

@ladamski ladamski commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Task: https://app.asana.com/1/137249556945/project/1209805270658160/task/1216337048997836?focus=true

Minimal changes here, so worth noting a small race condition present for querying the app version when:
a) fetching from CH
b) generating the report

The window is pretty tiny, but if we want to bullet proof we could also cache the ver from step a) in a file.


Note

Low Risk
Low-risk reporting and copy changes; version is fetched at report time (small mismatch vs validation fetch is documented) and untrusted version strings are escaped for Asana HTML.

Overview
Live validation Asana report copy now surfaces the target app version (when the product defines one) on the parent task and per-owner subtasks, plus a short note about possible false positives after pixel schema changes post-release.

Report generation resolves the version at run time via resolveTargetVersion from product.json’s target; products without a version (e.g. query-window) omit that block. Message building moved to asana_report_copy.mjs, with HTML escaping for the version string in rich-text notes.

Reviewed by Cursor Bugbot for commit d3e572d. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f86ee5d. Configure here.

Comment thread src/asana_report_copy.mjs Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the resolved target app version to Asana live-validation report intro text (including a warning about potential false positives if pixels changed after that release), and centralizes the report copy into a dedicated module.

Changes:

  • Introduces src/asana_report_copy.mjs to generate report intro HTML, optionally including an HTML-escaped target version and warning copy.
  • Updates live_validation_scripts/asana_reports.mjs to resolve the target version at report time via resolveTargetVersion and pass it into the copy helper.
  • Adds unit tests for version inclusion/omission and HTML escaping behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
tests/asana_report_copy_test.mjs Adds coverage for version/warning inclusion, omission for null target, and HTML escaping.
src/asana_report_copy.mjs New shared helper for Asana report intro copy, including optional target version + warning.
live_validation_scripts/asana_reports.mjs Uses shared copy helper and resolves target version at runtime for report tasks/subtasks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/asana_report_copy.mjs
Comment thread tests/asana_report_copy_test.mjs

@nshuba nshuba left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Race condition is also unlikely given the job runs on weekends and we avoid weekend releases. Probably worth a comment in the code though.

@ladamski
ladamski merged commit 15d418d into main Jul 17, 2026
3 checks passed
@ladamski
ladamski deleted the la/include-app-version-in-validation-reports branch July 17, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants