Skip to content

Dual live validation - #80

Open
ladamski wants to merge 5 commits into
mainfrom
la/dual-validation
Open

Dual live validation#80
ladamski wants to merge 5 commits into
mainfrom
la/dual-validation

Conversation

@ladamski

@ladamski ladamski commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Task: https://app.asana.com/1/137249556945/project/1209805270658160/task/1215852252524772?focus=true


Note

Medium Risk
Changes live validation alerting and the production Jenkins pixel job (release checkout and comparison logic); incorrect tag templates or comparator gaps could hide real failures or still miss edge cases.

Overview
Adds dual live validation: each product is checked against current branch definitions and a release snapshot resolved from the live app version, so alerts focus on failures that still apply to what shipped—not schema drift on main.

The Jenkins Jenkinsfile.params pipeline is consolidated around shared validationConfigs, per-product release tag templates, optional ASANA_PROJECT, and a single checkout stage that runs resolve_release_tag.mjs and checks out refs/tags/{tag} before validateRepo.sh receives an optional fourth release definitions path.

validate_live_pixel.mjs validates each CSV row against HEAD and, when a release dir is present, intersects undocumented and validation-failed results via stable error identities (live_validation_comparator.mjs, formatAjvErrorDetails). HEAD-only or release-only skew (e.g. extra param removed on one side) is suppressed; errors present on both sides remain.

applyNotifyOverride makes NOTIFY_PIXEL_OWNERS=false strip assignees/followers for test runs; release tag resolution and Jenkins wiring are covered by new tests.

Reviewed by Cursor Bugbot for commit 6738897. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread scripts/validateRepo.sh Outdated
@ladamski
ladamski requested a review from nshuba August 26, 2026 09:49

@nshuba nshuba left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments from an initial look - will take another later in the week. Thanks for starting this!

Comment thread scripts/resolve_release_tag.mjs
Comment thread scripts/validateRepo.sh Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8b2baa8. Configure here.

Comment thread Jenkinsfiles/Jenkinsfile.params
@ladamski ladamski changed the title live dual validation Dual live validation Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants