Dual live validation - #80
Open
ladamski wants to merge 5 commits into
Open
Conversation
nshuba
reviewed
Aug 26, 2026
nshuba
left a comment
Collaborator
There was a problem hiding this comment.
Left some comments from an initial look - will take another later in the week. Thanks for starting this!
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8b2baa8. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task: https://app.asana.com/1/137249556945/project/1209805270658160/task/1215852252524772?focus=true
Note
Medium Risk
Changes live validation alerting and the production Jenkins pixel job (release checkout and comparison logic); incorrect tag templates or comparator gaps could hide real failures or still miss edge cases.
Overview
Adds dual live validation: each product is checked against current branch definitions and a release snapshot resolved from the live app version, so alerts focus on failures that still apply to what shipped—not schema drift on
main.The Jenkins
Jenkinsfile.paramspipeline is consolidated around sharedvalidationConfigs, per-product release tag templates, optionalASANA_PROJECT, and a single checkout stage that runsresolve_release_tag.mjsand checks outrefs/tags/{tag}beforevalidateRepo.shreceives an optional fourth release definitions path.validate_live_pixel.mjsvalidates each CSV row against HEAD and, when a release dir is present, intersects undocumented and validation-failed results via stable error identities (live_validation_comparator.mjs,formatAjvErrorDetails). HEAD-only or release-only skew (e.g. extra param removed on one side) is suppressed; errors present on both sides remain.applyNotifyOverridemakesNOTIFY_PIXEL_OWNERS=falsestrip assignees/followers for test runs; release tag resolution and Jenkins wiring are covered by new tests.Reviewed by Cursor Bugbot for commit 6738897. Bugbot is set up for automated code reviews on this repo. Configure here.