Revert "Re-enable adsjs with no messaging" #3989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 957e2c7.
|
👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.
👉 Please mark this as DRAFT unless there's an intention to merge this immediately. |
Generated file outputs:Time updated: Tue, 28 Oct 2025 18:04:44 GMT legacy27 files identical
2 files changed
--- v4/android-config.json (and 1 other files)
+++ v4/android-config.json
@@ -395,14 +395,8 @@
"localeCountry": "us",
"isPrivacyProEligible": true
}
]
- },
- "updateScriptOnProtectionsChanged": {
- "state": "enabled"
- },
- "stopLoadingBeforeUpdatingScript": {
- "state": "disabled"
}
}
},
"androidNewStateKillSwitch": {
@@ -90186,21 +90180,8 @@
"path": "/additionalCheck",
"value": "disabled"
}
]
- },
- {
- "condition": {
- "injectName": "android",
- "minSupportedVersion": 52530000
- },
- "patchSettings": [
- {
- "op": "add",
- "path": "/additionalCheck",
- "value": "enabled"
- }
- ]
}
]
}
},
@@ -102130,19 +102111,8 @@
"clientContentFeatures": {
"state": "enabled",
"features": {
"useNewWebCompatApis": {
- "state": "enabled",
- "minSupportedVersion": 52530000,
- "rollout": {
- "steps": [
- {
- "percent": 50
- }
- ]
- }
- },
- "useWebMessageListener": {
"state": "disabled"
}
},
"exceptions": []
latestv5/android-config.json--- v5/android-config.json
+++ v5/android-config.json
@@ -395,14 +395,8 @@
"localeCountry": "us",
"isPrivacyProEligible": true
}
]
- },
- "updateScriptOnProtectionsChanged": {
- "state": "enabled"
- },
- "stopLoadingBeforeUpdatingScript": {
- "state": "disabled"
}
}
},
"androidNewStateKillSwitch": {
@@ -90186,21 +90180,8 @@
"path": "/additionalCheck",
"value": "disabled"
}
]
- },
- {
- "condition": {
- "injectName": "android",
- "minSupportedVersion": 52530000
- },
- "patchSettings": [
- {
- "op": "add",
- "path": "/additionalCheck",
- "value": "enabled"
- }
- ]
}
]
}
},
@@ -102130,19 +102111,8 @@
"clientContentFeatures": {
"state": "enabled",
"features": {
"useNewWebCompatApis": {
- "state": "enabled",
- "minSupportedVersion": 52530000,
- "rollout": {
- "steps": [
- {
- "percent": 50
- }
- ]
- }
- },
- "useWebMessageListener": {
"state": "disabled"
}
},
"exceptions": []
13 files identical
|
JSON approval analysis:Time updated: Tue, 28 Oct 2025 18:05:06 GMT legacy❌ Manual Review Required
latest❌ Manual Review Required
🎯 OVERALL APPROVAL STATUS❌ MANUAL REVIEW REQUIRED |
CrisBarreiro
deleted the
feature/cris/adsjs-config-tests/enable-adsjs-with-no-messages-revert
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 957e2c7.
Asana Task/Github Issue: https://app.asana.com/1/137249556945/task/1211767917352308?focus=true
Description
Revert config changes to stop using new WebView APIs
Feature change process:
Site breakage mitigation process:
Brief explanation
Note
Reverts prior adsjs-related changes by removing the Android conditional, disabling
useNewWebCompatApis, and dropping script-update flags inandroidBrowserConfig.overrides/android-override.json):useNewWebCompatApis: set todisabled(removes min version and rollout).useWebMessageListenerfeature.injectNameandroid(minSupportedVersion52530000).updateScriptOnProtectionsChangedandstopLoadingBeforeUpdatingScriptfeature flags underandroidBrowserConfig.features.disabledin affected features (no new adsjs enablement).Written by Cursor Bugbot for commit 8ab6f35. This will update automatically on new commits. Configure here.