fix: validate input schema using json schema validator#44
fix: validate input schema using json schema validator#44mhmd-azeez wants to merge 16 commits intomainfrom
Conversation
mhmd-azeez
force-pushed
the
validate-input-schema
branch
from
77dc6dc to
281657b
Compare
|
not sure why the obsidian plugin is failing to build |
There was a breaking change to the python-pdk. I will fix today. |
| "type": "object", | ||
| "oneOf": []interface{}{ | ||
| map[string]interface{}{ | ||
| "required": []string{"audio_path"}, | ||
| "not": map[string]interface{}{ | ||
| "required": []string{"audio_base64"}, | ||
| }, | ||
| }, | ||
| map[string]interface{}{ | ||
| "required": []string{"audio_base64"}, | ||
| "not": map[string]interface{}{ | ||
| "required": []string{"audio_path"}, | ||
| }, | ||
| }, | ||
| }, | ||
| "properties": map[string]interface{}{ | ||
| "audio_path": map[string]interface{}{ |
There was a problem hiding this comment.
The simulation can now handle complicated schemas like this too, @nilslice we just need to make sure the API/frontend can also handle it (when displaying it back on the website)
There was a problem hiding this comment.
awesome! i will try to use some of this code to help inform that update.
mhmd-azeez
force-pushed
the
validate-input-schema
branch
from
e533b55 to
d565095
Compare
mhmd-azeez
force-pushed
the
validate-input-schema
branch
from
1688b98 to
b8bbb37
Compare
…-emergency-npm-install-system fix: Makefile was missing npm install step
bhelx
left a comment
bhelx
left a comment
There was a problem hiding this comment.
Should we merge? still valid?
|
If the business requirement is still the same, then the PR i think is still valid |
| [[test]] | ||
| name = "describe output" | ||
| with = "../../simulations/describe-output/dist/plugin.wasm" No newline at end of file |
There was a problem hiding this comment.
what's the difference b/w using this local test and letting xtp handle the validation when pushing?
There was a problem hiding this comment.
I was mainly using this to make sure all of the servlets are passing the validation (since this new version hasn't been pushed to xtp yet)
|
Checking to see if this is still valid. If not let's close it. |
|
Checking in here to see what held us back from merging |
4 participants
Fixes https://github.com/dylibso/mcp.run/issues/248
Fixes https://github.com/dylibso/mcp.run/issues/265