Added data.vlan_groupS resource and added id field to data.vlan_group #787
+601
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hp197
force-pushed
the
feature/786-vlan-improvements
branch
from
b236604 to
1500525
Compare
hp197
force-pushed
the
feature/786-vlan-improvements
branch
from
1500525 to
5914db9
Compare
hp197
force-pushed
the
feature/786-vlan-improvements
branch
from
5914db9 to
d7a1231
Compare
hp197
commented
Oct 30, 2025
Comment on lines
-37
to
+43
| Type: schema.TypeInt, | ||
| Type: schema.TypeString, |
Author
There was a problem hiding this comment.
Reasoning: The api also expects a string:
https://github.com/fbreckle/go-netbox/blob/master/netbox/client/ipam/ipam_vlan_groups_list_parameters.go#L273
hp197
force-pushed
the
feature/786-vlan-improvements
branch
from
d7a1231 to
7e11820
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #786