Remove use of unsupported source key in patch spec
#4924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The easyconfig parser doesn't allow this key - The documentation doesn't mention it - No useage in easyblocks or framework are found - `finalpath` of all but the first source is `builddir` So just remove this code.
boegel
approved these changes
Jun 18, 2025
There was a problem hiding this comment.
Makes sense, since trying to use source key in patches entry leads to clear error:
For example with:
patches = [{'source': 0, 'name': 'test.patch'}]we get:
ERROR: ... Wrong patch spec '{'source': 0, 'name': 'test.patch'}', use of unknown key source in dict (valid keys are ['name', 'copy', 'level', 'sourcepath', 'alt_location', 'opts'])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finalpathof all but the first source isbuilddir, see Correctly detect final path when extracting multiple tarballs #4922So just remove this code.