Handle post_install_patches in GitHub uploads
#5016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
changed the title
Flamefire
changed the title
Flamefire
force-pushed
the
20251007085255_new_pr_IpOuRJvyQP
branch
from
b4db0fe to
c20477c
Compare
Flamefire
force-pushed
the
20251007085255_new_pr_IpOuRJvyQP
branch
from
c20477c to
6a7ffab
Compare
We already know the subdir and just need to append the path separator for the prefix-check
Flamefire
force-pushed
the
20251007085255_new_pr_IpOuRJvyQP
branch
from
6a7ffab to
2102678
Compare
boegel
changed the title
post_install_patches in GitHub uploads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)After #4980 supports postinstallpatches in extensions the GitHub upload had to be updated to check that list too.
While adding a test it turns out the regular (non-extension/component) postinstallpatches wasn't handled either, so fixing that too