fix: mitigate GITHUB_ENV injection in workflow_run workflow - #2113
Merged
Conversation
The publish-pr-check-content workflow reads PR_SHA from an
attacker-controlled artifact and writes it to $GITHUB_ENV without
validation, allowing fork PR authors to inject arbitrary environment
variables (BASH_ENV, PATH, LD_PRELOAD) and achieve code execution
with access to SURGE_TOKEN and the write-scoped GITHUB_TOKEN.
Mitigations applied:
- Replace artifact-sourced PR_SHA with github.event.workflow_run.head_sha
- Add ^[0-9a-f]{40}$ validation on the SHA (defense-in-depth)
- Add explicit permissions: statuses: write to restrict GITHUB_TOKEN scope
- Fix unquoted shell variables in find loops (prevents word-splitting attacks)
- Remove the now-unused pull-request-sha artifact from the producer workflow
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Valerii Svydenko <vsvydenk@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: svor The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Click here to review and test in web IDE: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The publish-pr-check-content workflow reads PR_SHA from an attacker-controlled artifact and writes it to $GITHUB_ENV without validation, allowing fork PR authors to inject arbitrary environment variables (BASH_ENV, PATH, LD_PRELOAD) and achieve code execution with access to SURGE_TOKEN and the write-scoped GITHUB_TOKEN.
Mitigations applied:
What does this PR do?
Screenshot/screencast of this PR
What issues does this PR fix or reference?
How to test this PR?
Release Notes
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.