-
Notifications
You must be signed in to change notification settings - Fork 446
iox-#2493: Add timeout during roudi shutdown operation #2500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#2493: Add timeout during roudi shutdown operation #2500
Conversation
5c1e9fb to
4cc1d89
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2500 +/- ##
==========================================
- Coverage 78.25% 78.23% -0.02%
==========================================
Files 446 446
Lines 17107 17111 +4
Branches 2373 2375 +2
==========================================
Hits 13387 13387
- Misses 2839 2841 +2
- Partials 881 883 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just skimmed over the changes and this took my attention. Will do a proper review once the CI is green.
| /// @return true if sucessful request/response, false on error | ||
| virtual bool sendRequestToRouDi(const IpcMessage& msg, IpcMessage& answer) noexcept = 0; | ||
| virtual bool | ||
| sendRequestToRouDi(const IpcMessage& msg, IpcMessage& answer, iox::units::Duration timeout = 0_s) noexcept = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use iox::Optional<iox::units::Duration> timour = iox::nullopt instead of a surrogate value.
|
It seems the |
2dc84e9 to
c605bab
Compare
…tToRouDi Signed-off-by: Luca Bartoli <[email protected]>
Add a 3-second timeout to the RouDi termination request to prevent deadlock arising from RouDi prematurely assuming the process has exited Signed-off-by: Luca Bartoli <[email protected]>
Signed-off-by: Luca Bartoli <[email protected]>
c605bab to
bc38c94
Compare
|
@elBoberido done! |
Notes for Reviewer
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch)iox-#123 commit text)task-list-completed)Checklist for the PR Reviewer
iceoryx_hoofshave been added to./clang-tidy-diff-scans.txtPost-review Checklist for the PR Author
References