Skip to content

Conversation

@lucabart97
Copy link
Contributor

@lucabart97 lucabart97 commented Oct 21, 2025

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of [CONTRIBUTING.md][contributing]
  2. Tests follow the [best practice for testing][testing]
  3. Changelog updated [in the unreleased section][changelog] including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this [guideline][commit-guidelines]
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit author matches [Eclipse Contributor Agreement][eca] (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@lucabart97 lucabart97 force-pushed the iox-2493-timed-receiver branch from 5c1e9fb to 4cc1d89 Compare October 21, 2025 17:22
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.23%. Comparing base (9e82c99) to head (bc38c94).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...oryx_posh/source/runtime/ipc_runtime_interface.cpp 25.00% 4 Missing and 2 partials ⚠️
iceoryx_posh/source/runtime/posh_runtime_impl.cpp 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2500      +/-   ##
==========================================
- Coverage   78.25%   78.23%   -0.02%     
==========================================
  Files         446      446              
  Lines       17107    17111       +4     
  Branches     2373     2375       +2     
==========================================
  Hits        13387    13387              
- Misses       2839     2841       +2     
- Partials      881      883       +2     
Flag Coverage Δ
unittests 78.03% <36.36%> (-0.02%) ⬇️
unittests_timing 15.30% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...yx_posh/internal/runtime/ipc_runtime_interface.hpp 100.00% <ø> (ø)
...posh/include/iceoryx_posh/runtime/posh_runtime.hpp 100.00% <ø> (ø)
iceoryx_posh/source/runtime/posh_runtime_impl.cpp 58.39% <66.66%> (ø)
...oryx_posh/source/runtime/ipc_runtime_interface.cpp 49.66% <25.00%> (-0.68%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just skimmed over the changes and this took my attention. Will do a proper review once the CI is green.

/// @return true if sucessful request/response, false on error
virtual bool sendRequestToRouDi(const IpcMessage& msg, IpcMessage& answer) noexcept = 0;
virtual bool
sendRequestToRouDi(const IpcMessage& msg, IpcMessage& answer, iox::units::Duration timeout = 0_s) noexcept = 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use iox::Optional<iox::units::Duration> timour = iox::nullopt instead of a surrogate value.

@elBoberido
Copy link
Member

It seems the https://www.avinsystems.com/products/agnosar-adaptive-platform/ link is dead and the product is not anymore advertised on that website. Could you please remove the link from the main README.md.

@lucabart97 lucabart97 force-pushed the iox-2493-timed-receiver branch 2 times, most recently from 2dc84e9 to c605bab Compare October 23, 2025 13:14
Add a 3-second timeout to the RouDi termination request to prevent
deadlock arising from RouDi prematurely assuming the process has
exited

Signed-off-by: Luca Bartoli <[email protected]>
@lucabart97 lucabart97 force-pushed the iox-2493-timed-receiver branch from c605bab to bc38c94 Compare October 23, 2025 13:23
@lucabart97
Copy link
Contributor Author

lucabart97 commented Oct 23, 2025

@elBoberido done!
I think the test is failed due to a timeout. If you rerun it, it should pass🤞🏻

@elBoberido elBoberido merged commit 2304cb2 into eclipse-iceoryx:main Oct 24, 2025
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

~PoshRuntimeImpl(): does not exit

2 participants