Fix infix rule CST issues #2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // The specified item could be a datatype ($type is symbol), fragment ($type is undefined) or infix rule ($infix exists) | ||
| // Only if the $type is a string, we actually assign the element | ||
| if (typeof item.$type === 'string') { | ||
| if (typeof item.$type === 'string' && !('$infix' in item)) { |
There was a problem hiding this comment.
Wrt. performance: Would it be advantageous to add $infix?: boolean to the type def of item and just test !item.$infix?
There was a problem hiding this comment.
I don't think it matters, but it makes it more readable 👍
msujew
force-pushed
the
msujew/fix-infix-operator-cst
branch
from
9afd63a to
b6855fc
Compare
|
@msujew should sth like this still happen with 4.0.1 
|
|
@cdietrich Not really, but I'm not sure whether it's actually feasible to rewrite the whole CST during the binary operation AST rewrite. I'm quite unhappy with the feature myself (see also #1733) - it works better in another project where we embed the CST in the AST (non-langium project). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #2011 which fixes an issue where the infix rules object was stored in the CST
astNodeitem by accident.