Add JMH benchmarks to jsonrpc #929
Open
+208
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds some basic benchmarks to serve as a starting point for future benchmarking work. On the CI we build the benchmarks, but we don't run them.
Contributor
Author
Contributor
|
It is very useful to have some benchmark infrastructure like this ready to use. However regarding JMH I'd like to point out that it is GPL licensed. I once tried to add JMH benchmarks to TM4E but it was rejected by the project lead for legal concerns at the time. Maybe better check with Eclipse Legal team first. |
Contributor
|
@sebthom may I ask why? Jmh is distributed under GPL v2 with classpath exception. Also adding jmh plugin does not add jmh itself to the redistributed package, so it should be fine. But I'm not a lawyer. |
Contributor
|
Me neither, that was the PR eclipse-tm4e/tm4e#389 I just wanted to bring this to attention. Maybe it is not a problem after all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds some basic benchmarks to serve as a starting point for future benchmarking work.
On the CI we build the benchmarks, but we don't run them.