Skip to content

Conversation

smurfix
Copy link

@smurfix smurfix commented May 22, 2024

As this class attribute is actually useful,
make the code fit the comment.

This also saves a bit of time and memory because the map was recreated for each ReasonCode instance.

smurfix added 7 commits May 22, 2024 17:10
As this class attribute is actually useful,
make the code fit the comment.
Thus (a) "foo in dict.keys()" is better written as "foo in dict"
and (b) "print(foo.keys())" won_t do what you want
that's what a single-underscore _methodName is intended for
instead of scanning it
@smurfix
Copy link
Author

smurfix commented May 28, 2024

I added hopefully-uncontroversial fixes for a couple of other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant