Skip to content

Conversation

@TorstenHirsch
Copy link
Contributor

Description

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@stephanbcbauer stephanbcbauer added this to the 25.12 milestone Oct 3, 2025
@stephanbcbauer stephanbcbauer added the KIT KIT related content, mapped to TRactus-X releases label Oct 3, 2025
@github-project-automation github-project-automation bot moved this from Inbox to Todo in Tractus-X Webpage Oct 6, 2025
Copy link
Member

@jSchuetz88 jSchuetz88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TorstenHirsch thank you for the PR and the overall maintenance and small improvements. I didn't had the chance to build ist yet, but I found some broken links (see comment below).


2. Quality Investigation: This notification is sent from the OEM / Tier n-1 to a supplier and indicates a problem or failure of parts delivered by the supplier. The problem may be detected by the OEM / Tier n-1, e.g., during incoming goods inspection or end of line test. The specification for this notification is shared with the [Traceability KIT](https://eclipse-tractusx.github.io/docs-kits/next/kits/traceability-kit/Architecture%20View%20Traceability%20Kit#quality-investigations--quality-alerts).

3. Quality Alert: This notification is sent from the supplier to an OEM / Tier n-1 and indicates a problem or failure of parts delivered by the supplier. The problem may be detected by the supplier, e.g., end of line test or via a notification from another customer. The specification for this notification is shared with the [Traceability KIT](https://eclipse-tractusx.github.io/docs-kits/next/kits/traceability-kit/Architecture%20View%20Traceability%20Kit#quality-investigations--quality-alerts).

This comment was marked as resolved.

@stephanbcbauer
Copy link
Member

Friendly reminder -> final KIT PR 17.11. -> earlier would be of course beneficial :)

@stephanbcbauer stephanbcbauer requested a review from a team November 19, 2025 06:21
@stephanbcbauer
Copy link
Member

@eclipse-tractusx/automotive-tractusx-committers i am not available for the next days, please support here to merge the changes. They are relevant for Release 25.12 Thx

@TorstenHirsch
Copy link
Contributor Author

TorstenHirsch commented Nov 24, 2025 via email

@stephanbcbauer
Copy link
Member

@TorstenHirsch i won't be available for the next 4 days. Please try to fix the "requested changes", aftwards it would be good if @Grand-Thibault would do a pre check and afters this, one of the @eclipse-tractusx/automotive-tractusx-committers can check (and merge)

Copy link
Member

@stephanbcbauer stephanbcbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution:

  • Please use kebapb-case for the svg names
  • Please add the KIT to masterdata if not already done
  • res.text can be deleted?
  • there are open issues, notet by @jSchuetz88 -> broken links
  • @Grand-Thibault and one task for you

@jSchuetz88
Copy link
Member

I just saw: please update the changelog accordingly.

Copy link
Contributor

@matbmoser matbmoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the information about this KIT (Version and Last Update Date) in the KIT Master Data:

https://eclipse-tractusx.github.io/docs/release/trg-10/trg-10-01#master-data

@stephanbcbauer
Copy link
Member

Good morning, after review/discussion with @ther3sa and @jSchuetz88

@TorstenHirsch This PR needs to be merged today/tomorrow because we need to execute the versioning plug-in tomorrow, to prepare the release 25.12 To provide the state for the KIT, please merge main into your branch. To get the new master data file.

For more details about the new structure, please ask @matbmoser

@stephanbcbauer
Copy link
Member

meeting with @TorstenHirsch , @ther3sa , @jSchuetz88 , @stephanbcbauer => KIT will be ready tomorrow for our 25.12 release

@TorstenHirsch
Copy link
Contributor Author

@jSchuetz88 @stephanbcbauer All changes should now be included.

Copy link
Member

@stephanbcbauer stephanbcbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @TorstenHirsch for you contribution. Looks very good. We have to wait for @matbmoser approval, since he also requested changes

Copy link
Member

@jSchuetz88 jSchuetz88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the fixes.

@TorstenHirsch
Copy link
Contributor Author

TorstenHirsch commented Dec 2, 2025 via email

@stephanbcbauer stephanbcbauer dismissed matbmoser’s stale review December 2, 2025 12:32

kitsData.js was adapted -> LGTM

@stephanbcbauer stephanbcbauer merged commit e1cfeac into eclipse-tractusx:main Dec 2, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Tractus-X Webpage Dec 2, 2025
@matbmoser
Copy link
Contributor

thank you very much for the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

KIT KIT related content, mapped to TRactus-X releases

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants