-
Notifications
You must be signed in to change notification settings - Fork 24
Feat workflow for TM contribution #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TejInaco
wants to merge
26
commits into
eclipse:master
Choose a base branch
from
TejInaco:feature-3-phase-workflow-for-TM-contribution
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat workflow for TM contribution #148
TejInaco
wants to merge
26
commits into
eclipse:master
from
TejInaco:feature-3-phase-workflow-for-TM-contribution
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for editdor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Ricardo M G da Silva <[email protected]>
Signed-off-by: Ricardo M G da Silva <[email protected]>
Signed-off-by: Ricardo M G da Silva <[email protected]>
Signed-off-by: Ricardo M G da Silva <[email protected]>
Signed-off-by: Ricardo M G da Silva <[email protected]>
Signed-off-by: Ricardo M G da Silva <[email protected]>
Review on the UI-level:
|
Signed-off-by: Ricardo M G da Silva <[email protected]>
Considerations from the Second Review:
note: use of test tmcSubmission.json |
Signed-off-by: Ricardo M G da Silva <[email protected]>
56d47af
to
f9ec046
Compare
Signed-off-by: Ricardo M G da Silva <[email protected]>
…ttings Signed-off-by: Ricardo M G da Silva <[email protected]>
Signed-off-by: Ricardo M G da Silva <[email protected]>
Signed-off-by: Ricardo M G da Silva <[email protected]>
Signed-off-by: Ricardo M G da Silva <[email protected]>
Signed-off-by: Ricardo M G da Silva <[email protected]>
Signed-off-by: Ricardo M G da Silva <[email protected]>
Signed-off-by: Ricardo M G da Silva <[email protected]>
Signed-off-by: Ricardo M G da Silva <[email protected]>
Signed-off-by: Ricardo M G da Silva <[email protected]>
Signed-off-by: Ricardo M G da Silva <[email protected]>
Signed-off-by: Ricardo M G da Silva <[email protected]>
Signed-off-by: Ricardo M G da Silva <[email protected]>
Signed-off-by: Ricardo M G da Silva <[email protected]>
Another review:
|
Signed-off-by: Ricardo M G da Silva <[email protected]>
Signed-off-by: Ricardo M G da Silva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will implement #140
This pull request introduces a three-phase workflow triggered by clicking the "Contribute To Catalog" button.
The workflow consists of the following steps:
Users can edit the following Thing Model (TM) fields:
Model (required)
Author (required)
Manufacturer (required)
License
Copyright Year
Copyright Holder
Validation is performed on the required fields. Successful validation is mandatory to proceed to Step 2.
This step allows users to test the TM. A Thing Description (TD) is generated in the background using values provided in the Instance and Gateway sections.
It includes four subsections:
2.1) Instance:
Users can fill in all dynamic values, i.e., placeholders in the TM such as {{some_value}}.
2.2) Gateway:
Users can configure southbound and northbound settings, reusing the logic from the existing Settings component. A refactor was performed to enable component reuse.
2.3) Value Verification:
Users can interact with TM properties that include "readproperty" in the op key. These properties are displayed in a table with the following columns: Property Name; Title; Preview Value
Users can test properties individually or all at once. In case of errors:
The name of the failing property is displayed.
For multiple errors, the first failing property is shown along with a counter.
The page number in the table is highlighted in red.
2.4) Saving Results:
This feature will be implemented in a future issue.
All sections include error handling mechanisms.
This step retains previously implemented features and completes the workflow.
Additional Notes
A progress bar guides users through the workflow.
Components will be refactored for reuse and logic extraction to improve maintainability and extend unit test coverage.