Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Comments

Parse headers via regexp #5

Open
dhoko wants to merge 1 commit intoeface2face:masterfrom
ProtonMail:fix/parseHeaders
Open

Parse headers via regexp #5
dhoko wants to merge 1 commit intoeface2face:masterfrom
ProtonMail:fix/parseHeaders

Conversation

@dhoko
Copy link

@dhoko dhoko commented Oct 1, 2018

Hey,

I've found this issue using the lib:

console.js:35 Error: parseHeaderValue() failed for image/png; filename="Fleshing out a sketch of a bird for a friend! - ;.png"; name="Fleshing out a sketch of a bird for a friend! - ;.png"
    at u (parse.js:214)

The parsing of headers was done via ; and as it's inside the name here it creates a bug.
So instead of using this ; I replaced it via something from REGEXP_PARAM.
A test will cover this use case now :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant