Skip to content

Conversation

@sobomax
Copy link

@sobomax sobomax commented Feb 9, 2016

Add new "-M" option, which when used in conjunction with "-w" will cause gitinspector output both monthly and weekly stats for the period in question. It is useful in some cases to have both.

cause gitinspector output *both* monthly and weekly stats for the
period in question.
@adam-waldenberg
Copy link
Member

Hi @sobomax.

Yes, there might be some credence to adding this. I'm not completely convinced, but it is definitely worth considering.

Some problems with the pull request, before this can even be considered for merging;

  • Needs "git config" support (see config.py), which also means we need a long option for this.
  • How do we handle the Age column of the blame output ? As it is now, it shows time in either weeks or months.

@sobomax
Copy link
Author

sobomax commented Feb 9, 2016

Hi @adam-waldenberg, both suggestions have been implemented. Please check and let me know if anything else needs to be done. Thanks!

@adam-waldenberg
Copy link
Member

Thank you. I will play with this. I'm wondering if a -M flag is the best option for this... Maybe removing -w and introducing a "--period" flag that takes a string such as "m" (for months) or "wm" (for weeks and months) would be an idea... It would also make it more flexible. I'm torn, though. I need to think about it :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants