-
Notifications
You must be signed in to change notification settings - Fork 2
[0027] Formatter for Ekapkgs #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
solid assessment, as a personal user of alexandra can't really argue |
|
agree as well, I miss that container space |
| - Not actively maintained | ||
| - Not predictable formatting | ||
| - It's more "convergent", rather than deterministic | ||
| - Sometimes requires the tool to be ran many times to converge to final state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neither have I. But I would also write pretty close to what nixpgks-fmt would output
|
TIL I learned alejandra added experimental configuration options. Perhaps instead of forking, upstream would accept a patch to optionally re-enable container space? |
|
One downside of alejandra is that its IDE support does not progressively parse errors, so if an error occurs, it exits with an error code and a small error pop-up occurs in VSCode. I might be mixing up formatting and LSP/linting, but as a total experience, there's room for improvement. Still, the output is nice and the codebase is healthy. I like it. |
|
Two things mentioned on Discord are:
If active maintenance is a lower factor, forking one and applying moderate changes might also be an option. |
|
I would like to investigate nixpkgs-fmt, I'm fine with not everything being super deterministic. I just want readibility. |

Formatters help to avoid a lot of potential merge conflicts and review churn.