Skip to content

Conversation

@nrdxp
Copy link
Member

@nrdxp nrdxp commented Oct 7, 2025

Include much of the details from eka's style guide directly in the EEP
to be a bit more self-contained.
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really opinionated, and this looks reasonable.


# Acknowledgements

Thanks to the original authors of the `STYLE_GUIDE.md` for establishing a strong foundation for this proposal. Special thanks to @jonringer for his ongoing efforts in eka-ci and in driving ekapkgs forward.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@nrdxp
Copy link
Member Author

nrdxp commented Oct 8, 2025

one setting of the rustfmt config in particular that might warrant some further scrutiny is: imports_granularity = "Module" (doc)

Tried to strike a balance from the default Crate (which is honestly very cluttered and ugly), and the Item which might be beneficial for minimal diffs, but is also quite verbose. However, maybe minimal diffs should be the priority? Just something to consider.

The easiest way to enforce sorting is with LLMs, but without very
explicit instructions, they get confused and produced mixed results on
the order of various types. For that reason, we shall be very explicit
about how to sort types to alleviate this ambiguity and hopefully ease
automation.
Comment on lines +77 to +78
Types (`struct`, `enum`, and `type` aliases) must be sorted as a single, interlaced group, alphabetically by their identifier.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's next? fascism?

lol

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean in practice it's never going to be perfect, but it's just a helpful guideline to try to maintain some semblance of organization in large modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants