Fix psycopg_pool instrumentation to restore Postgres spans #2460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
github-actions
bot
added
agent-python
community
JaeHyuckSa
force-pushed
the
fix/psycopg-pool-instrumentation
branch
from
0b6bbdd to
a1200b5
Compare
xrmx
reviewed
Oct 30, 2025
There was a problem hiding this comment.
Thanks for the PR. We are using - as separator so the test framework name should be called psycopg_pool and reqs and envs file should be renamed. Also in order to run tests in CI you need to add an entry psycopg_pool-newest in .ci/.matrix_framework.yml and .ci/.matrix_framework_full.yml.
|
@JaeHyuckSa The tests file name was good, the requirements and environments one are wrong. Also the matrix files update is missing. |
JaeHyuckSa
force-pushed
the
fix/psycopg-pool-instrumentation
branch
2 times, most recently
from
4ed3c00 to
c30e88b
Compare
Signed-off-by: SaJH <[email protected]>
JaeHyuckSa
force-pushed
the
fix/psycopg-pool-instrumentation
branch
from
c30e88b to
e67babb
Compare
|
@xrmx Thank you for the review. I was going to make some other changes back then but forgot about it… I’ve now reflected everything you mentioned! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Related issues
Closes #2094