Fix: Add owner reference to existing resources when initially missing #8835
+80
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes elastic#8718 ReconcileResource now checks and updates owner references independently of the NeedsUpdate function. Previously, if a resource existed without an owner reference and NeedsUpdate returned false (because data, labels, and annotations were unchanged), the owner reference would never be added. Changes: Added owner reference check before the NeedsUpdate block in ReconcileResource Owner references are now added to existing resources even when other fields don't require updates Added test case to verify owner reference is added when NeedsUpdate returns false The fix ensures proper resource ownership management and enables garbage collection for resources that were created before owner references were implemented.
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8718
Problem
ReconcileResource does not add owner references to existing resources that were created without an owner. This occurs when
NeedsUpdate()returns false (because data, labels, and annotations haven't changed), causing the update block which contains the owner reference logic to be skipped entirely.Solution
Added a separate owner reference check that runs independently of
NeedsUpdate(). This makes sure that owner references are added or updated on existing resources even when no other fields require updates.Changes
NeedsUpdateblock inReconcileResourceAdd owner reference to existing resource without owner when NeedsUpdate returns falseto verify the fixTesting
This fix enables proper resource ownership management and garbage collection for resources created before owner references were implemented.