Skip to content

ui: add flamescope#73

Open
florianl wants to merge 1 commit intomainfrom
flamescope
Open

ui: add flamescope#73
florianl wants to merge 1 commit intomainfrom
flamescope

Conversation

@florianl
Copy link
Member

Add a flamescope tab to investigate patterns.

Example output:

2026-02-14_11-50

Add a flamescope tab to investigate patterns.

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
@florianl florianl requested a review from a team as a code owner February 14, 2026 10:52
@christos68k
Copy link
Member

christos68k commented Feb 17, 2026

I tested it and it works, but there seems to be a bug (not sure if macOS-specific) where if I try to select a region in the flamescope with click-dragging, I can't do it on the initial click as it won't let me drag the region. I have to click a second time and then I can proceed with dragging.

To reproduce, in the flamescope view:

  1. Click "Clear Selection"
  2. Initiate a click-drag (you should see that you can't drag the region)
  3. Try another click-drag (this time it'll work)

Copy link

@rogercoll rogercoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on Linux as well, code lgtm too. I noticed the same bug that @christos68k describes, just on the first click the selection draws a line. Subsequent clicks works as expected, allowing the user to select a region

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants