Open
Conversation
Add a flamescope tab to investigate patterns. Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
Member
|
I tested it and it works, but there seems to be a bug (not sure if macOS-specific) where if I try to select a region in the flamescope with click-dragging, I can't do it on the initial click as it won't let me drag the region. I have to click a second time and then I can proceed with dragging. To reproduce, in the flamescope view:
|
rogercoll
reviewed
Feb 18, 2026
rogercoll
left a comment
There was a problem hiding this comment.
Works on Linux as well, code lgtm too. I noticed the same bug that @christos68k describes, just on the first click the selection draws a line. Subsequent clicks works as expected, allowing the user to select a region
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a flamescope tab to investigate patterns.
Example output: